| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Towards easier AMs: Cleaning up inappropriate use of name "relkind" |
| Date: | 2020-06-03 17:26:28 |
| Message-ID: | 20200603172628.GA21064@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Jun-03, Mark Dilger wrote:
> The name "relkind" normally refers to a field of type 'char' with
> values like 'r' for "table" and 'i' for "index". In AlterTableStmt
> and CreateTableAsStmt, this naming convention was abused for a field
> of type enum ObjectType.
I agree that "relkind" here is a misnomer, and I bet that what happened
here is that the original patch Gavin developed was using the relkind
enum from pg_class and was later changed to the OBJECT_ defines after
patch review, but the struct member name remained. I don't object to
the proposed renaming.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jerome Wagner | 2020-06-03 17:28:12 | question regarding copyData containers |
| Previous Message | Mark Dilger | 2020-06-03 17:05:26 | Towards easier AMs: Cleaning up inappropriate use of name "relkind" |