Re: segmentation fault using currtid and partitioned tables

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: segmentation fault using currtid and partitioned tables
Date: 2020-06-01 02:20:55
Message-ID: 20200601022055.GB4121@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 01, 2020 at 10:57:29AM +0900, Michael Paquier wrote:
> Applied this one then. I also got to check the ODBC driver in more
> details, and I am indeed not seeing those functions getting used.
> One extra thing to know is that the ODBC driver requires libpq from at
> least 9.2, which may give one more argument to just remove them.
>
> NB: prion has been failing, just looking into it.

Woah. This one is old, good catch from -DRELCACHE_FORCE_RELEASE. It
happens that since its introduction in a3519a2 from 2002,
currtid_for_view() in tid.c closes the view and then looks at a RTE
from it. I have reproduced the issue and the patch attached takes
care of the problem. Would it be better to backpatch all the way down
or is that not worth caring about?
--
Michael

Attachment Content-Type Size
currtid-view-relcache.patch text/x-diff 675 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-06-01 02:26:54 Re: segmentation fault using currtid and partitioned tables
Previous Message Tom Lane 2020-06-01 02:07:29 Re: Compatible defaults for LEAD/LAG