Re: BufFileRead() error signalling

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: BufFileRead() error signalling
Date: 2020-05-28 07:10:12
Message-ID: 20200528071012.GD3460@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 27, 2020 at 11:59:59AM -0400, Alvaro Herrera wrote:
> In the discussion that led to 811b6e36a9e2 I did suggest to use "read
> only M of N" instead, but there wasn't enough discussion on that fine
> point so we settled on what you now call prevalent without a lot of
> support specifically on that. I guess it was enough of an improvement
> over what was there. But like Robert, I too prefer the wording that
> includes "only" and "bytes" over the wording that doesn't.
>
> I'll let it be known that from a translator's point of view, it's a
> ten-seconds job to update a fuzzy string from not including "only" and
> "bytes" to one that does. So let's not make that an argument for not
> changing.

Using "only" would be fine by me, though I tend to prefer the existing
one. Now I think that we should avoid "bytes" to not have to worry
about pluralization of error messages. This has been a concern in the
past (see e5d11b9 and the likes).
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2020-05-28 07:16:08 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
Previous Message Michael Paquier 2020-05-28 06:44:26 Re: max_slot_wal_keep_size comment in postgresql.conf