hash join error improvement (old)

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: hash join error improvement (old)
Date: 2020-05-25 23:02:20
Message-ID: 20200525230220.GA21348@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I recently noticed this in a customer log file:
ERROR: could not read from hash-join temporary file: Success

The problem is we're reporting with %m when the problem is a partial
read or write.

I propose the attached patch to solve it: report "wrote only X of X
bytes". This caused a lot of other trouble, the cause of which I've
been unable to pinpoint as yet. But in the meantime, this is already a
small improvement.

--
Álvaro Herrera

Attachment Content-Type Size
hashjoin.patch text/x-diff 2.4 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-05-25 23:33:12 Re: hash join error improvement (old)
Previous Message Tomas Vondra 2020-05-25 22:59:09 Re: Trouble with hashagg spill I/O pattern and costing