Re: pgindent && weirdness

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>, sysadmins(at)lists(dot)postgresql(dot)org
Subject: Re: pgindent && weirdness
Date: 2020-05-18 18:48:44
Message-ID: 20200518184844.GB13712@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> > It seems I cannot. Please go ahead.
>
> [ yawn... ] It's about bedtime here, but I'll take care of it in the
> morning.
>
> Off the critical path, we oughta figure out why the repo wouldn't
> let you commit. What I was told was it was set up to be writable
> by all PG committers.

Just happened to see this. Might be I'm not looking at the right thing,
but from what I can tell, the repo is set up with only you as having
write access. We also don't currently have updating the pg_bsd_indent
repo on git.postgresql.org as part of our SOP for adding/removing
committers.

All of this is fixable, of course. I've CC'd this to sysadmins@ to
highlight this issue and possible change to that repo and our SOP.

Barring complaints or concerns, based on Tom's comments above, I'll
adjust that repo to be 'owned' by pginfra, with all committers having
read/write access, and add it to our committer add/remove SOP to
update that repo's access list whenever there are changes.

I'll plan to do that in a couple of days to allow for any concerns or
questions, as this isn't a critical issue at present based on the above
comments.

Thanks,

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Vik Fearing 2020-05-18 19:27:26 Re: Missing grammar production for WITH TIES
Previous Message Tom Lane 2020-05-18 18:26:55 Re: Two fsync related performance issues?