From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
Subject: | Re: pg_stat_wal_receiver and flushedUpto/writtenUpto |
Date: | 2020-05-15 17:43:11 |
Message-ID: | 20200515174311.GA2699@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020-May-15, Michael Paquier wrote:
> As discussed in the thread that introduced d140f2f3 to rename
> receivedUpto to flushedUpto and add writtenUpto to the WAL receiver's
> shared memory information, the equivalent columns in
> pg_stat_wal_receiver have not been renamed:
> When I have implemented this system view, the idea was to keep a
> one-one mapping between the SQL interface and the shmem info even if
> we are not compatible with past versions, hence I think that before
> beta1 we had better fix that and:
> - rename received_lsn to flushed_lsn.
> - add one column for writtenUpto.
Why do you put the column at the end? I would put written_lsn before
flushed_lsn.
Since this requires a catversion bump, I think it'd be best to do it
before beta1 next week.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Shichao Jin | 2020-05-15 18:22:49 | Spawned Background Process Knows the Exit of Client Process? |
Previous Message | Alvaro Herrera | 2020-05-15 17:26:19 | Re: Add A Glossary |