| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | bossartn(at)amazon(dot)com, alvherre(at)2ndquadrant(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)lists(dot)postgresql(dot)org, ah(at)cybertec(dot)at, andres(at)anarazel(dot)de |
| Subject: | Re: pg13: xlogreader API adjust |
| Date: | 2020-05-15 11:18:58 |
| Message-ID: | 20200515111858.GB212736@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 14, 2020 at 02:12:25PM +0900, Kyotaro Horiguchi wrote:
> Good catch! That's not only for CreateDecodingContet. That happens
> everywhere in the query loop in PostgresMain() until logreader is
> initialized. So that also happens, for example, by starting logical
> replication using invalidated slot. Checking xlogreader != NULL in
> WalSndErrorCleanup is sufficient. It doesn't make actual difference,
> but the attached explicitly initialize the pointer with NULL.
Alvaro, are you planning to look at that? Should we have an open item
for this matter?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2020-05-15 11:48:53 | Re: Problem with logical replication |
| Previous Message | Amit Kapila | 2020-05-15 11:05:32 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |