Re: Event trigger code comment duplication

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Event trigger code comment duplication
Date: 2020-05-13 07:48:59
Message-ID: 20200513074859.GQ88791@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 12, 2020 at 10:26:46PM -0700, David G. Johnston wrote:
> On Tuesday, May 12, 2020, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> Even with all that, I am not sure that we need to complicate further
>> what we have here. An empty currentEventTriggerState gets checks in
>> three places, and each one of them has a slight different of the
>> reason why we cannot process further, so I would prefer applying my
>> previous, simple patch if there are no objections to remove the
>> duplication about event triggers with standalone mode, keeping the
>> explanations local to each event trigger type, and call it a day.
>
> I’ll defer at this point - though maybe keep/improve the fix for the
> quadruple negative and related commentary.

Still not sure that's worth bothering. So, let's wait a couple of
days first to see if anybody has any comments, though I'd like to just
go with the simplest solution at hand and remove only the duplicated
comment about the standalone business with event triggers.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2020-05-13 08:13:07 Re: Add "-Wimplicit-fallthrough" to default flags
Previous Message Michael Paquier 2020-05-13 07:43:19 Re: gcov coverage data not full with immediate stop