From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Сергей Черкашин <s(dot)cherkashin(at)postgrespro(dot)ru>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
Subject: | Re: pgsql: Show opclass and opfamily related information in psql |
Date: | 2020-05-12 18:09:58 |
Message-ID: | 20200512180958.GA11266@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
I would appreciate opinions from the patch authors on this ordering
change (rationale in previous email). I forgot to CC Sergei and Nikita.
> diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c
> index 8dca6d8bb4..9bd0bf8356 100644
> --- a/src/bin/psql/describe.c
> +++ b/src/bin/psql/describe.c
> @@ -6288,7 +6288,11 @@ listOpFamilyOperators(const char *access_method_pattern,
> processSQLNamePattern(pset.db, &buf, family_pattern, have_where, false,
> "nsf.nspname", "of.opfname", NULL, NULL);
>
> - appendPQExpBufferStr(&buf, "ORDER BY 1, 2, o.amopstrategy, 3;");
> + appendPQExpBufferStr(&buf, "ORDER BY 1, 2,\n"
> + " o.amoplefttype = o.amoprighttype DESC,\n"
> + " pg_catalog.format_type(o.amoplefttype, NULL),\n"
> + " pg_catalog.format_type(o.amoprighttype, NULL),\n"
> + " o.amopstrategy;");
>
> res = PSQLexec(buf.data);
> termPQExpBuffer(&buf);
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2020-05-12 18:17:01 | pgsql: Rework EXPLAIN format for incremental sort |
Previous Message | Tom Lane | 2020-05-12 17:03:58 | pgsql: Do pre-release housekeeping on catalog data. |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-05-12 18:11:34 | Re: Our naming of wait events is a disaster. |
Previous Message | Andrey M. Borodin | 2020-05-12 17:51:23 | Re: Our naming of wait events is a disaster. |