Re: Logical replication subscription owner

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, alvherre(at)2ndquadrant(dot)com, chris+postgresql(at)qwirx(dot)com, pgsql-docs(at)lists(dot)postgresql(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org, peter(dot)eisentraut(at)2ndquadrant(dot)com
Subject: Re: Logical replication subscription owner
Date: 2020-05-09 18:09:33
Message-ID: 20200509180933.GN13712@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

Greetings,

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
> > Not to make the life of everybody more complicated here, but I don't
> > agree. LOGIN and REPLICATION are in my opinion completely orthogonal
> > and it sounds more natural IMO that a REPLICATION user should be able
> > to log into the server only if it has LOGIN defined.
>
> ISTM those statements are contradictory. The two privileges could
> only be called orthogonal if it's possible to make use of one without
> having the other. As things stand, REPLICATION without LOGIN is an
> entirely useless setting.

Allowing a login to the system by a role that doesn't have the LOGIN
privilege isn't sensible though.

Perhaps a middle ground would be to set LOGIN on a role when REPLICATION
is set on it, if it's not already set (maybe with a NOTICE or WARNING or
such saying "also enabling LOGIN for role X", or maybe not if people
really think it should be obvious).

I don't think taking away login should take away replication though as
maybe there's some reason why someone would want that, nor should we
take away login if replication is taken away, this would strictly just
be a change for when REPLICATION is added to a role that doesn't have
LOGIN already.

Thanks,

Stephen

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Tom Lane 2020-05-09 18:22:18 Re: Logical replication subscription owner
Previous Message Tom Lane 2020-05-09 18:09:01 Re: Another modest proposal for docs formatting: catalog descriptions

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-05-09 18:15:01 Re: Add -Wold-style-definition to CFLAGS?
Previous Message Tom Lane 2020-05-09 18:09:01 Re: Another modest proposal for docs formatting: catalog descriptions