| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Should smgrdounlink() be removed? |
| Date: | 2020-05-07 11:33:27 |
| Message-ID: | 20200507113327.GF11539@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 07, 2020 at 04:57:00PM +0900, Fujii Masao wrote:
> On 2020/05/07 13:49, Michael Paquier wrote:
>> On Thu, May 07, 2020 at 09:48:35AM +0530, vignesh C wrote:
>> > I could not find any code reference to smgrdounlink, I feel it can be
>> > removed.
>>
>> The last use of smgrdounlink() was b416691. I have just looked at
>> Debian Code Search and github, and could not find a hit with the
>> function being used in some custom extension code, so it feels like a
>> safe bet to remove it.
>
> +1
So this gives the attached. Any thoughts?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| smgrunlink-remove-v1.patch | text/x-diff | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | دار الآثار للنشر والتوزيع-صنعاء Dar Alathar-Yemen | 2020-05-07 11:48:40 | رد: BUG #16419: wrong parsing BC year in to_date() function |
| Previous Message | Ranier Vilela | 2020-05-07 11:32:13 | Re: Postgres Windows build system doesn't work with python installed in Program Files |