Re: pgsql: Fix handling of WAL segments ready to be archived during crash r

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix handling of WAL segments ready to be archived during crash r
Date: 2020-04-24 01:14:37
Message-ID: 20200424011437.GA806193@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Apr 24, 2020 at 09:59:29AM +0900, Michael Paquier wrote:
> And this visibly comes down to the fact that we don't take care enough
> of the timing between the restartpoints done, the startup process
> doing its recycling work and the archiver. The rest of the test
> relies on the reports of pg_stat_archiver a points to wait at as
> published by the archiver process. So there are two things we could
> do here:
> 1) Just remove the unstable parts of the tests (the three ones above),
> and keep coverage based on everything we have using pg_stat_archiver.
> 2) Remove the test entirely, though I would rather have us keep some
> coverage, particularly for primaries as this got broken.
>
> I'd rather do 2), any thoughts?

Oops, sorry. I sent this message too quickly. I would rather
actually do 1) and keep the major parts of the tests. All the
buildfarm failures are just around the three checks mentioned
upthread.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2020-04-24 02:35:13 pgsql: Remove some unstable parts from new TAP test for archive status
Previous Message Michael Paquier 2020-04-24 00:59:29 Re: pgsql: Fix handling of WAL segments ready to be archived during crash r