| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: backup manifests |
| Date: | 2020-04-23 21:16:29 |
| Message-ID: | 20200423211629.payzm7rr6gkubpa4@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2020-04-23 08:57:39 -0400, Robert Haas wrote:
> On Sun, Apr 5, 2020 at 3:31 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > The warnings don't seem too unreasonable. The compiler can't see that
> > the error_cb inside json_manifest_parse_failure() is not expected to
> > return. Probably worth adding a wrapper around the calls to
> > context->error_cb and mark that as noreturn.
>
> Eh, how? The callback is declared as:
>
> typedef void (*json_manifest_error_callback)(JsonManifestParseContext *,
> char
> *fmt, ...) pg_attribute_printf(2, 3);
>
> I don't know of a way to create a wrapper around that, because of the
> variable argument list.
Didn't think that far...
> We could change the callback to take va_list, I guess.
I'd argue that that'd be a good idea anyway, otherwise there's no way to
wrap the invocation anywhere in the code. But that's an independent
consideration, as:
> Does it work for you to just add pg_attribute_noreturn() to this
> typedef, as in the attached?
does fix the problem for me, cool.
Do you not see a warning when compiling with optimizations enabled?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2020-04-23 22:09:36 | Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays |
| Previous Message | James Coleman | 2020-04-23 20:12:34 | Re: [PATCH] Fix division by zero (explain.c) |