| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, masao(dot)fujii(at)oss(dot)nttdata(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [BUG] non archived WAL removed during production crash recovery |
| Date: | 2020-04-22 01:19:35 |
| Message-ID: | 20200422011935.GF33034@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Wed, Apr 22, 2020 at 12:41:21AM +0200, Jehan-Guillaume de Rorthais wrote:
> Do we need to acquire info_lck to look at the state here, as we do in
> GetRecoveryState()? Why is it missing from previous code where
> SharedRecoveryInProgress was protected by info_lck as well?
Please see 1a3d104.
> Plus, the new line length overflow the 80-column, but I'm not sure where to
> break this line.
pgindent has been run on v8, and it did not complain.
> In fact, this was inherited from 011_crash_recovery.pl where I originally
> added some tests. As 020_archive_status.pl doesn't use IPC::Run, the comment is
> wrong. But I wonder if this whole block is really needed. Unfortunately I can't
> test on MSWin32 :/
You are right here. The restriction can be removed, and I have
checked that the test from v8 is able to pass on my Windows dev VM.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2020-04-22 03:17:11 | Re: pg_stat_statements: rows not updated for CREATE TABLE AS SELECT statements |
| Previous Message | Bruce Momjian | 2020-04-22 01:17:22 | Re: BUG #16380: documentation: host[no]gssenc vs. address/IP-address/IP-mask fields |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2020-04-22 01:25:14 | Re: MYSQL_FDW trigger BEFORE UPDATE changes to NEW on a col not in the update statement don't go through |
| Previous Message | Kyotaro Horiguchi | 2020-04-22 01:12:46 | Re: Remove page-read callback from XLogReaderState. |