| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Antonin Houska <ah(at)cybertec(dot)at> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: 2pc leaks fds |
| Date: | 2020-04-21 23:54:22 |
| Message-ID: | 20200421235422.GA28667@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Apr-08, Antonin Houska wrote:
> Specifically for 2PC, isn't it better to close some OS-level FD of an
> unrelated table scan and then succeed than to ERROR immediately? Anyway,
> 0dc8ead46 hasn't changed this.
I think for full generality of the interface, we pass a "close" callback
in addition to the "open" callback. But if we were to pass it only for
WALRead, then there would be no way to call it during XLogReaderFree.
I think the fix Andres applied is okay as far as it goes, but for the
long term we may want to change the interface even further -- maybe by
having these functions be part of the XLogReader state struct. I have
this code paged out of my head ATM, but maybe tomorrow I can give it a
little think.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-04-21 23:56:36 | Re: ALTER TABLE ... SET STORAGE does not propagate to indexes |
| Previous Message | Alvaro Herrera | 2020-04-21 23:31:57 | Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql: Support FETCH FIRST WITH TIES) |