Re: DETACH PARTITION and FOR EACH ROW triggers on partitioned tables

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Amit Langote <amitlangote09(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: DETACH PARTITION and FOR EACH ROW triggers on partitioned tables
Date: 2020-04-21 16:45:10
Message-ID: 20200421164510.GJ3890@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 21, 2020 at 12:20:38PM -0400, Alvaro Herrera wrote:
> diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
> index 7595e609b5..233905552c 100644
> --- a/doc/src/sgml/ref/alter_table.sgml
> +++ b/doc/src/sgml/ref/alter_table.sgml
> @@ -941,13 +943,14 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
> <term><literal>DETACH PARTITION</literal> <replaceable class="parameter">partition_name</replaceable></term>
> <listitem>
> <para>
> This form detaches specified partition of the target table. The detached
> partition continues to exist as a standalone table, but no longer has any
> ties to the table from which it was detached. Any indexes that were
> - attached to the target table's indexes are detached.
> + attached to the target table's indexes are detached. Any triggers that
> + were created to mirror those in the target table are removed.

Can you say "cloned" here instead of mirror ?
> + attached to the target table's indexes are detached. Any triggers that
> + were created as clones of triggers in the target table are removed.

Also, I see in the surrounding context a missing word?
This form detaches THE specified partition of the target table.

--
Justin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2020-04-21 18:01:28 Re: design for parallel backup
Previous Message yuzuko 2020-04-21 16:21:04 Re: Autovacuum on partitioned table (autoanalyze)