Re: [patch] some PQExpBuffer are not destroyed in pg_dump

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
Cc: "Zhang, Jie" <zhangjie2(at)cn(dot)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [patch] some PQExpBuffer are not destroyed in pg_dump
Date: 2020-04-15 07:05:10
Message-ID: 20200415070510.GL1492@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 14, 2020 at 10:11:56AM +0900, Michael Paquier wrote:
> Indeed. Any code path of pg_dump calling buildACLQueries() clears up
> things, and I think that it is a better practice to clean up properly
> PQExpBuffer stuff even if there is always the argument that pg_dump
> is a tool running in a "short"-term context. So I will backpatch that
> unless there are any objections from others.

And done as of 8f4ee44.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey M. Borodin 2020-04-15 07:13:57 Allow pg_read_all_stats to read pg_stat_progress_*
Previous Message davinder singh 2020-04-15 06:08:16 Re: PG compilation error with Visual Studio 2015/2017/2019