Re: doc review for parallel vacuum

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: doc review for parallel vacuum
Date: 2020-04-13 08:30:15
Message-ID: 20200413083015.GQ2228@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 13, 2020 at 10:44:42AM +0530, Amit Kapila wrote:
> On Fri, Apr 10, 2020 at 7:16 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> >
> > Also, this part still doesn't read well:
> >
> > - * amvacuumcleanup to the DSM segment if it's the first time to get it?
> > - * from them? because they? allocate it locally and it's possible that an
> > - * index will be vacuumed by the different vacuum process at the next
> >
> > If you change "it" and "them" and "it" and say "*a* different", then it'll be
> > ok.
> >
>
> I am not sure if I follow how exactly you want to change it but still
> let me know what you think about if we change it like: "Copy the index
> bulk-deletion result returned from ambulkdelete and amvacuumcleanup to
> the DSM segment if it's the first time because they allocate locally
> and it's possible that an index will be vacuumed by the different
> vacuum process at the next time."

I changed "the" to "a" and removed "at":

|Copy the index
|bulk-deletion result returned from ambulkdelete and amvacuumcleanup to
|the DSM segment if it's the first time [???] because they allocate locally
|and it's possible that an index will be vacuumed by a different
|vacuum process the next time."

Is it correct to say: "..if it's the first iteration" and "different process on
the next iteration" ? Or "cycle" ?

--
Justin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message tushar 2020-04-13 08:37:14 Re: [Proposal] Global temporary tables
Previous Message 曾文旌 2020-04-13 08:27:59 Re: [Proposal] Global temporary tables