Re: relcache leak warnings vs. errors

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: relcache leak warnings vs. errors
Date: 2020-04-11 08:28:41
Message-ID: 20200411082841.fjygcnrxdpxhtarg@nol
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Apr 11, 2020 at 10:09:59AM +0200, Peter Eisentraut wrote:
> I just fixed a relcache leak that I accidentally introduced (5a1d0c9925).
> Because it was a TAP test involving replication workers, you don't see the
> usual warning anywhere unless you specifically check the log files manually.
>
> How about a compile-time option to turn all the warnings in resowner.c into
> errors? This could be enabled automatically by --enable-cassert, similar to
> other defines that that option enables.
>

+1. Would it be worthwhile to do the same in e.g. aset.c (for
MEMORY_CONTEXT_CHECKING case), or more generally for stuff in
src/backend/utils?

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Rijkers 2020-04-11 09:04:21 Re: proposal - psql - possibility to redirect only tabular output
Previous Message Pavel Stehule 2020-04-11 08:21:32 Re: proposal - psql - possibility to redirect only tabular output