Re: doc review for v13

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
Subject: Re: doc review for v13
Date: 2020-04-10 06:29:02
Message-ID: 20200410062902.GX1606@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 09, 2020 at 10:01:51PM -0500, Justin Pryzby wrote:
> On Fri, Apr 10, 2020 at 11:27:46AM +0900, Michael Paquier wrote:
>> required pages to remove both downlink and rightlink are already locked. That
>> -evades potential right to left page locking order, which could deadlock with
>> +avoid potential right to left page locking order, which could deadlock with
>> Not sure which one is better, but the new change is grammatically
>> incorrect.
>
> "Evades" usually means to act to avoid detection by the government. Like tax
> evasion.

This change is from Alexander Korotkov as of 32ca32d, so I am adding
him in CC to get his opinion.

>> <varname>auto_explain.log_settings</varname> controls whether information
>> - about modified configuration options are printed when execution plan is logged.
>> - Only options affecting query planning with value different from the built-in
>> + about modified configuration options is printed when an execution plan is logged.
>> + Only those options which affect query planning and whose value differs from its built-in
>> Depends on how you read the sentence, but here is seemt to me that
>> "statistics" is the correct subject, no?
>
> Statistics ?

Oops. I may have messed up with a different part of the patch set.
Your suggestion is right as the subject is "information" here.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2020-04-10 07:04:16 Re: Function to track shmem reinit time
Previous Message Amit Kapila 2020-04-10 06:16:46 Re: WAL usage calculation patch