From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: doc review for v13 |
Date: | 2020-04-10 03:01:51 |
Message-ID: | 20200410030150.GZ2228@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Apr 10, 2020 at 11:27:46AM +0900, Michael Paquier wrote:
> On Wed, Apr 08, 2020 at 11:56:53AM -0500, Justin Pryzby wrote:
> > I previously mailed separately about a few individual patches, some of which
> > have separate, ongoing discussion and aren't included here (incr sort, parallel
> > vacuum).
>
> I have gone through your changes, and committed what looked like the
> most obvious mistakes in my view. Please see below for more
> comments.
Thanks - rebased for cfbot and continued review.
> required pages to remove both downlink and rightlink are already locked. That
> -evades potential right to left page locking order, which could deadlock with
> +avoid potential right to left page locking order, which could deadlock with
> Not sure which one is better, but the new change is grammatically
> incorrect.
Thanks for noticing
"Evades" usually means to act to avoid detection by the government. Like tax
evasion.
> <varname>auto_explain.log_settings</varname> controls whether information
> - about modified configuration options are printed when execution plan is logged.
> - Only options affecting query planning with value different from the built-in
> + about modified configuration options is printed when an execution plan is logged.
> + Only those options which affect query planning and whose value differs from its built-in
> Depends on how you read the sentence, but here is seemt to me that
> "statistics" is the correct subject, no?
Statistics ?
> <literal>_tz</literal> suffix. These functions have been implemented to
> - support comparison of date/time values that involves implicit
> + support comparison of date/time values that involve implicit
> The subject is "comparison" here, no?
You're right.
--
Justin
Attachment | Content-Type | Size |
---|---|---|
v2-0001-doc-psql-opclass-opfamily.patch | text/x-diff | 2.8 KB |
v2-0002-doc-percent-encoding.patch | text/x-diff | 1.4 KB |
v2-0003-docs-btree-deduplication.patch | text/x-diff | 1.1 KB |
v2-0004-doc-pg_stat_progress_basebackup.patch | text/x-diff | 1.6 KB |
v2-0005-docs-backup-manifests.patch | text/x-diff | 4.9 KB |
v2-0006-Fix-docs-time-of-the.patch | text/x-diff | 3.1 KB |
v2-0007-docs-Add-wait-events-for-recovery-conflicts.patch | text/x-diff | 1.3 KB |
v2-0008-doc-Allow-users-to-limit-storage-reserved-by-repl.patch | text/x-diff | 1.5 KB |
v2-0009-docs-s-evade-avoid.patch | text/x-diff | 1.8 KB |
v2-0010-doc-2014-pg_basebackup-Add-support-for-relocating.patch | text/x-diff | 1.0 KB |
v2-0011-Say-it-more-naturally.patch | text/x-diff | 9.0 KB |
v2-0012-is-vs-are-plural.patch | text/x-diff | 2.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2020-04-10 03:32:31 | Re: Multiple FPI_FOR_HINT for the same block during killing btree index items |
Previous Message | Kyotaro Horiguchi | 2020-04-10 02:59:20 | Re: [HACKERS] Restricting maximum keep segments by repslots |