| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Vacuum o/p with (full 1, parallel 0) option throwing an error |
| Date: | 2020-04-09 07:57:02 |
| Message-ID: | 20200409075702.GM2228@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 09, 2020 at 12:31:55PM +0530, Amit Kapila wrote:
> Sure, we can change that, but isn't the existing example of similar
> message "cannot specify both PARSER and COPY options" occurs when
> both the options have valid values? If so, we can use a similar
> principle here, no?
A better comparison is with this one:
src/bin/pg_dump/pg_restore.c: pg_log_error("cannot specify both --single-transaction and multiple jobs");
but it doesn't say just: "..specify both --single and --jobs", which would be
wrong in the same way, and which we already dealt with some time ago:
commit 14a4f6f3748df4ff63bb2d2d01146b2b98df20ef
Author: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Date: Tue Apr 14 00:06:35 2009 +0000
pg_restore -jN does not equate "multiple jobs", so partly revert the
previous patch.
Per note from Tom.
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2020-04-09 08:07:48 | Re: Vacuum o/p with (full 1, parallel 0) option throwing an error |
| Previous Message | Fujii Masao | 2020-04-09 07:35:22 | Re: [HACKERS] make async slave to wait for lsn to be replayed |