Re: 2pc leaks fds

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Antonin Houska <ah(at)cybertec(dot)at>, pgsql-hackers(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Subject: Re: 2pc leaks fds
Date: 2020-04-08 06:29:59
Message-ID: 20200408062959.GH1606@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 07, 2020 at 05:12:49PM -0700, Andres Freund wrote:
> I pushed a fix. While it might not be the best medium/long term fix, it
> unbreaks 2PC. Perhaps we should add an open item to track whether we
> want to fix this differently?

Sounds fine to me. I have updated the open item that we have now by
adding a comment that the leak has been fixed by 91c4054, but that
we should revisit the refactoring.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2020-04-08 06:35:24 Re: Use compiler intrinsics for bit ops in hash
Previous Message Masahiko Sawada 2020-04-08 06:23:00 Re: pg_stat_statements issue with parallel maintenance (Was Re: WAL usage calculation patch)