Re: pgsql: Include information on buffer usage during planning phase, in EX

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Fujii Masao <fujii(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Include information on buffer usage during planning phase, in EX
Date: 2020-04-03 02:58:22
Message-ID: 20200403025751.GB1759@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi Fujii-san,

On Fri, Apr 03, 2020 at 02:28:27AM +0000, Fujii Masao wrote:
> Include information on buffer usage during planning phase, in EXPLAIN output.
>
> When BUFFERS option is enabled, EXPLAIN command includes the information
> on buffer usage during each plan node, in its output. In addition to that,
> this commit makes EXPLAIN command include also the information on
> buffer usage during planning phase, in its output. This feature makes it
> easier to discern the cases where lots of buffer access happen during
> planning.

prion did not like that:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2020-04-03%2002%3A33%3A13

Here is the diff from test explain:
@@ -73,8 +73,9 @@
Seq Scan on int8_tbl i8 (cost=N.N..N.N rows=N width=N) (actual time=N.N..N.N rows=N loops=N)
Buffers: shared [read]
Planning Time: N.N ms
+ Buffers: shared [read]
Execution Time: N.N ms
-(4 rows)
+(5 rows)

Note that this animal uses -DRELCACHE_FORCE_RELEASE and
-DCATCACHE_FORCE_RELEASE.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2020-04-03 03:16:30 pgsql: Add wait events for recovery conflicts.
Previous Message Michael Paquier 2020-04-03 02:46:33 pgsql: Add support for \aset in pgbench