Re: [BUG] non archived WAL removed during production crash recovery

Sorry, it was quite ambiguous.

At Thu, 02 Apr 2020 13:04:43 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> At Wed, 1 Apr 2020 18:17:35 +0200, Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com> wrote in
> > Please, find in attachment a patch implementing this.
>
> The patch partially reintroduces the issue the patch have
> fixed. Specifically a standby running a crash recovery wrongly marks a
> WAL file as ".ready" if it is extant in pg_wal without accompanied by
> .ready file.

The patch partially reintroduces the issue the commit 78ea8b5daa have
fixed. Specifically a standby running a crash recovery wrongly marks a
WAL file as ".ready" if it is extant in pg_wal without accompanied by
.ready file.

> Perhaps checking '.ready' before the checking for archive-mode would
> be sufficient.
>
> > Plus, I added a second commit to add one test in regard with this bug.
> >
> > > Another is to make the startup process remove .ready file if necessary.
> >
> > I'm not sure to understand this one.

--
Kyotaro Horiguchi
NTT Open Source Software Center