Re: Ecpg dependency

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: Filip Janus <fjanus(at)redhat(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Ecpg dependency
Date: 2020-03-31 18:18:31
Message-ID: 20200331181831.GA17676@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Mar 21, 2020 at 06:13:03PM -0400, Bruce Momjian wrote:
> On Sat, Mar 21, 2020 at 07:30:48PM +0000, Dagfinn Ilmari Mannsåker wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > On Sat, Mar 21, 2020 at 02:14:44PM -0400, Bruce Momjian wrote:
> > > Oh, I forgot to mention I got this line from
> > > src/interfaces/libpq/Makefile:
> >
> > And that line is wrong, but my patch to fix it¹ seems to have fallen
> > between the cracks.
> >
> > [1] https://www.postgresql.org/message-id/flat/871rsa13ae.fsf%40wibble.ilmari.org
> >
> > Adding the dependency to `all-lib` only fixes it for serial builds. To
> > fix it properly, so it works with parallel builds (e.g. 'make -j4 -C
> > src/interfaces/ecpg', the dependency needs to be declared via
> > SHLIB_PREREQS, as attached
>
> Oh, good catch. I did not notice that patch before. Adding that change
> to src/interfaces/ecpg/pgtypeslib/Makefile fixes the stand-alone
> compile.

Patch applied and backpatched to PG 12. Thanks.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message James Coleman 2020-03-31 18:23:15 Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Previous Message Robert Haas 2020-03-31 18:10:34 Re: backup manifests