| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: error context for vacuum to include block number |
| Date: | 2020-03-25 11:39:17 |
| Message-ID: | 20200325113917.GT21443@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 25, 2020 at 04:54:41PM +0530, Amit Kapila wrote:
> On Wed, Mar 25, 2020 at 3:42 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> >
> > Attached patch addressing these.
> >
>
> Thanks, you forgot to remove the below declaration which I have
> removed in attached.
Yes I saw..
> Apart from this, I have ran pgindent and now I think it is in good
> shape. Do you have any other comments? Sawada-San, can you also
I did just notice/remember while testing trucate that autovacuum does this:
src/backend/postmaster/autovacuum.c: errcontext("automatic vacuum of table \"%s.%s.%s\"",
And that appears to be interacting correctly. For example if you add an
elog(ERROR) and run UPDATE/DELETE, and wait autovacuum_naptime, then it shows
both contexts.
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Coleman | 2020-03-25 12:14:41 | Re: improve transparency of bitmap-only heap scans |
| Previous Message | Amit Kapila | 2020-03-25 11:24:41 | Re: error context for vacuum to include block number |