Re: pgsql: pg_dump: Add FOREIGN to ALTER statements, if appropriate

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Erik Rijkers <er(at)xs4all(dot)nl>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: pg_dump: Add FOREIGN to ALTER statements, if appropriate
Date: 2020-03-20 21:12:22
Message-ID: 20200320211222.GA18361@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2020-Mar-20, Erik Rijkers wrote:

> pg_dump.c: In function ‘dumpTrigger’:
> pg_dump.c:17469:51: error: ‘foreign’ undeclared (first use in this
> function); did you mean ‘fopen’?
> appendPQExpBuffer(query, "\nALTER %sTABLE %s ", foreign,
> ^~~~~~~
> fopen
> pg_dump.c:17469:51: note: each undeclared identifier is reported only once
> for each function it appears in

Yeah, last-minute edit lacking "git add". Pushing now.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2020-03-20 21:14:40 pgsql: Fix bogus last-minute edit in 4e62091341b4
Previous Message Erik Rijkers 2020-03-20 20:50:59 Re: pgsql: pg_dump: Add FOREIGN to ALTER statements, if appropriate