Re: Portal->commandTag as an enum

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Portal->commandTag as an enum
Date: 2020-03-16 21:41:58
Message-ID: 20200316214158.GA12425@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-Mar-04, Mark Dilger wrote:

>
>
> > On Mar 2, 2020, at 1:57 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> >
> > I pushed it now.
>
> Thanks again! While rebasing some other work on top, I noticed one of your comments is out of date:
>
> --- a/src/include/tcop/cmdtaglist.h
> +++ b/src/include/tcop/cmdtaglist.h
> @@ -23,7 +23,7 @@
> * textual name, so that we can bsearch on it; see GetCommandTagEnum().
> */
>
> -/* symbol name, textual name, event_trigger_ok, table_rewrite_ok, rowcount, last_oid */
> +/* symbol name, textual name, event_trigger_ok, table_rewrite_ok, rowcount */

Oops. Pushed, thanks.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2020-03-16 21:48:06 Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)
Previous Message Andres Freund 2020-03-16 21:34:59 Re: Berserk Autovacuum (let's save next Mandrill)