From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | time for catalog/pg_cast.c? |
Date: | 2020-03-09 21:00:03 |
Message-ID: | 20200309210003.GA19992@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I extracted from the latest multirange patch a bit that creates a new
routine CastCreate() in src/backend/catalog/pg_cast.c. It contains the
catalog-accessing bits to create a new cast. It seems harmless, so I
thought I'd apply it to get rid of a couple of hunks in the large patch.
(I also threw in a move of get_cast_oid from functioncmds.c to
lsyscache.c, which seems its natural place; at first I thought to put it
in catalog/pg_cast.c but really it's not a great place IMO. This
function was invented out of whole cloth in commit fd1843ff8979. I also
contemplated the move of CreateCast and DropCastById from functioncmds.c
to some new place, but creating a new commands/castcmds.c seemed a bit
excessive, so I left them in their current locations.)
--
Álvaro Herrera 39°49'30"S 73°17'W
"The problem with the future is that it keeps turning into the present"
(Hobbes)
Attachment | Content-Type | Size |
---|---|---|
pg_cast.patch | text/x-diff | 11.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2020-03-09 21:14:44 | Re: time for catalog/pg_cast.c? |
Previous Message | David Rowley | 2020-03-09 20:56:08 | Re: Berserk Autovacuum (let's save next Mandrill) |