| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Paul Jungwirth <pj(at)illuminatedcomputing(dot)com> |
| Subject: | Re: useless RangeIOData->typiofunc |
| Date: | 2020-03-05 15:02:40 |
| Message-ID: | 20200305150240.GA8064@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Mar-05, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > Thanks -- ISTM it makes more sense to put the FmgrInfo before the
> > typioparam too:
>
> > typedef struct RangeIOData
> > {
> > TypeCacheEntry *typcache; /* range type's typcache entry */
> > FmgrInfo proc; /* element type's I/O function */
> > Oid typioparam; /* element type's I/O parameter */
> > } RangeIOData;
>
> Yeah, WFM. Maybe even rename the FmgrInfo to "typioproc"
> or the like?
Good idea, thanks! Pushed with that change.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2020-03-05 15:12:14 | Re: Retiring support for pre-7.3 FK constraint triggers |
| Previous Message | David Steele | 2020-03-05 14:56:40 | Re: Retiring support for pre-7.3 FK constraint triggers |