Re: useless RangeIOData->typiofunc

On 2020-Mar-04, Tom Lane wrote:

> Hm, I'm not sure that really lessens the cognitive load any, but
> if you do commit this please fix the dangling reference you left
> in the nearby comment:
>
> {
> TypeCacheEntry *typcache; /* range type's typcache entry */
> - Oid typiofunc; /* element type's I/O function */
> Oid typioparam; /* element type's I/O parameter */
> FmgrInfo proc; /* lookup result for typiofunc */
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^
> } RangeIOData;

Thanks -- ISTM it makes more sense to put the FmgrInfo before the
typioparam too:

typedef struct RangeIOData
{
TypeCacheEntry *typcache; /* range type's typcache entry */
FmgrInfo proc; /* element type's I/O function */
Oid typioparam; /* element type's I/O parameter */
} RangeIOData;

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services