Re: Cast to uint16 in pg_checksum_page()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Cast to uint16 in pg_checksum_page()
Date: 2020-03-04 12:52:08
Message-ID: 20200304125208.GK2593@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 04, 2020 at 07:02:43AM -0500, David Steele wrote:
> Yes, this is being included in an external project. Previously we have used
> a highly marked-up version but we are now trying to pull in the header more
> or less verbatim.
>
> Since this header is specifically designated as something external projects
> may want to use I think it makes sense to fix the warning.

This sounds like a sensible argument, similar to the ones raised on
the other thread, so no objections from me to improve things here. I
can look at that tomorrow, except if somebody else beats me to it.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-03-04 12:55:48 Re: PG_COLOR not mentioned in docs of vacuumlo, oid2name and pgbench
Previous Message Hamid Akhtar 2020-03-04 12:45:38 Re: Minor issues in .pgpass