Re: Portal->commandTag as an enum

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>
Cc: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Portal->commandTag as an enum
Date: 2020-02-28 20:54:16
Message-ID: 20200228205416.GA14159@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-Feb-21, John Naylor wrote:

> Thinking about this some more, would it be possible to treat these
> like we do parser/kwlist.h? Something like this:
>
> commandtag_list.h:
> PG_COMMANDTAG(ALTER_ACCESS_METHOD, "ALTER ACCESS METHOD", true, false,
> false, false)
> ...

I liked this idea, so I'm halfway on it now.

> I'm hand-waving a bit, and it doesn't have the flexibility of a .dat
> file, but it's a whole lot simpler.

Yeah, I for one don't want to maintain the proposed DataFile.pm.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-02-28 22:09:34 Re: Less-silly selectivity for JSONB matching operators
Previous Message Jeff Davis 2020-02-28 20:38:55 Re: Add LogicalTapeSetExtend() to logtape.c