From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Bernd Helmle <mailings(at)oopsware(dot)de> |
Cc: | Michael Banck <michael(dot)banck(at)credativ(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [Patch] Make pg_checksums skip foreign tablespace directories |
Date: | 2020-02-25 02:33:09 |
Message-ID: | 20200225023309.GB17153@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Feb 24, 2020 at 01:11:10PM +0100, Bernd Helmle wrote:
> The other makes scan_directories() complicated to read and special
> cases just a single directory in an otherwise more or less generic
> function. E.g. it makes me uncomfortable if we get a pg_tblspc
> somewhere else than PGDATA (if someone managed to create such a
> directory in a foreign tablespace location for example), so we should
> maintain an additional check if we really operate on the pg_tblspc we
> have to. That was the reason(s) i've moved it into a separate function.
We are just discussing about the code path involving scanning a
directory, so that does not seem that bad to me. I really think that
we should avoid duplicating the same logic around, and that we should
remain consistent with non-directory entries in those paths,
complaining with a proper failure if extra, unwanted files are
present.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-02-25 02:33:54 | Re: client-side fsync() error handling |
Previous Message | Michael Paquier | 2020-02-25 02:05:05 | Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions? |