| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Clean up some code, comments and docs referring to Windows 2000 |
| Date: | 2020-02-20 03:02:40 |
| Message-ID: | 20200220030240.GG2288@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Feb 19, 2020 at 04:01:54PM -0500, Tom Lane wrote:
> Surely this patch broke the error case in haveNativeWindowsIPv6routines()?
> That is, in the admittedly unlikely case that LoadLibraryA("ws2_32")
> succeeds but GetProcAddress(hLibrary, "getaddrinfo") doesn't, what you
> now have will do FreeLibrary(hLibrary) and then proceed to use the
> now-dangling hLibrary pointer anyway.
You are right, thanks! This block has no meaning anymore, so
removed.
For the note, it looks that we could get completely rid of
src/port/getaddrinfo.c once we drop support for XP as IPv6 support is
enabled by default on Vista and Windows 7. For XP, one needs to
install an extra module manually. Do you think that there are other
platforms using our port implementation for getaddrinfo() except
Windows? That's not material for today, obviously.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-02-20 06:27:53 | Re: pgsql: Clean up some code, comments and docs referring to Windows 2000 |
| Previous Message | Michael Paquier | 2020-02-20 03:02:13 | pgsql: Cleanup more code related to ws2_32.dll loading in src/port/geta |