Re: pgsql: Test additional speculative conflict scenarios.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Test additional speculative conflict scenarios.
Date: 2020-02-12 05:07:17
Message-ID: 20200212050717.GA1464@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, Feb 12, 2020 at 12:43:09AM +0000, Andres Freund wrote:
> Test additional speculative conflict scenarios.
>
> Previously, the speculative insert tests did not cover the case when a
> tuple t is inserted into a table with a unique index on a column but
> before it can insert into the index, a concurrent transaction has
> inserted a conflicting value into the index and the insertion of tuple t
> must be aborted.

guaibasaurus is unhappy after this commit:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=guaibasaurus&dt=2020-02-12%2004%3A17%3A03

Here is the culprit diff:
application_namelocktype mode granted

+ transactionid ExclusiveLock t
isolation/insert-conflict-specconflict-s1speculative tokenShareLock f
isolation/insert-conflict-specconflict-s1transactionid ExclusiveLock t
isolation/insert-conflict-specconflict-s2speculative tokenExclusiveLock t
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2020-02-12 05:10:38 Re: pgsql: Test additional speculative conflict scenarios.
Previous Message Michael Paquier 2020-02-12 04:34:08 pgsql: Add %x to default PROMPT1 and PROMPT2 in psql