| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: widen vacuum buffer counters |
| Date: | 2020-02-05 20:18:08 |
| Message-ID: | 20200205201808.GA30278@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Jan-31, Tom Lane wrote:
> Also, %zd is the wrong format code for int64. Recommended practice
> these days is to use "%lld" with an explicit cast of the printf argument
> to long long (just to be sure). That doesn't work safely before v12,
> and if you did insist on back-patching further, you'd need to jump
> through hoops to avoid having platform-specific format codes in a
> translatable string. (The side-effects for translation seem like
> an independent argument against back-patching.)
Pushed with that change; did not backpatch, because I don't think it's
really worth the possible breakage :-)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mahendra Singh Thalor | 2020-02-05 20:26:58 | Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager |
| Previous Message | Jeff Davis | 2020-02-05 19:56:11 | Re: Memory-Bounded Hash Aggregation |