From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | parens cleanup |
Date: | 2020-01-29 20:04:01 |
Message-ID: | 20200129200401.GA6303@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Some ereport calls have excess sets of parentheses. patch 0001 removes
the ones I found in a very quick grep.
0002 removes newlines immediately following parens. These were
previously useful because pgindent would move arguments further to the
left so that the line would fit under 80 chars. However, pgindent no
longer does that, so the newlines are pointless and ugly.
These being cosmetic cleanups, they're not intended for backpatch,
though an argument could be made that doing that would save some future
backpatching pain. If ther are sufficient votes for that, I'm open to
doing it. (Of course, 0002 would not be backpatched further back than
pg10, the first release that uses the "new" pgindent rules.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0001-Remove-excess-parens-in-ereport-calls.patch | text/x-diff | 39.0 KB |
0002-fix-useless-newlines-after-parens.patch | text/x-diff | 97.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2020-01-29 20:29:19 | Re: Marking some contrib modules as trusted extensions |
Previous Message | Peter Geoghegan | 2020-01-29 19:50:26 | Re: Enabling B-Tree deduplication by default |