| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | hlinnaka(at)iki(dot)fi |
| Cc: | alvherre(at)2ndquadrant(dot)com, andres(at)anarazel(dot)de, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Remove page-read callback from XLogReaderState. |
| Date: | 2020-01-21 10:45:10 |
| Message-ID: | 20200121.194510.1739385716713850152.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello.
At Mon, 20 Jan 2020 17:24:07 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> Separating XLogBeginRead seems reasonable. The annoying recptr trick
> is no longer needed. In particular some logical-decoding stuff become
> far cleaner by the patch.
>
> fetching_ckpt of ReadRecord is a bit annoying but that coundn't be
> moved outside to, say, ReadCheckpointRecord in a clean way. (Anyway
> XLogBeginRead is not the place, of course).
>
> As I looked through it, it looks good to me but give me some more time
> to look closer.
It seems to me that it works perfectly, and everything looks good to
me except one point.
- * In this case, the passed-in record pointer should already be
+ * In this case, EndRecPtr record pointer should already be
I'm not confident but isn't the "record pointer" redundant? EndRecPtr
seems containing that meaning, and the other occurances of that kind
of variable names are not accompanied by that.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2020-01-21 11:33:40 | Re: Remove page-read callback from XLogReaderState. |
| Previous Message | Julien Rouhaud | 2020-01-21 10:21:20 | Re: Planning counters in pg_stat_statements (using pgss_store) |