From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
Cc: | Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Stephen Frost <sfrost(at)snowman(dot)net>, Chapman Flack <chap(at)anastigmatix(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Greatest Common Divisor |
Date: | 2020-01-20 19:04:14 |
Message-ID: | 20200120190414.GA32010@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020-Jan-20, Dean Rasheed wrote:
> + <entry>
> + greatest common divisor — the largest positive number that
> + divides both inputs with no remainder; returns <literal>0</literal> if
> + both inputs are zero
> + </entry>
Warning, severe TOC/bikeshedding ahead.
I don't know why, but this dash-semicolon sequence reads strange to me
and looks out of place. I would use parens for the first phrase and
keep the semicolon, that is "greatest common divisor (the largest ...);
returns 0 if ..."
That seems more natural to me, and we're already using parens in other
description <entry>s.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2020-01-20 19:11:20 | Re: error context for vacuum to include block number |
Previous Message | Tom Lane | 2020-01-20 19:03:29 | Re: [HACKERS] kqueue |