Re: pgsql: Add a non-strict version of jsonb_set

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add a non-strict version of jsonb_set
Date: 2020-01-19 20:20:23
Message-ID: 20200119202022.GO32763@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, Jan 19, 2020 at 12:46:19PM -0500, Tom Lane wrote:
> David Fetter <david(at)fetter(dot)org> writes:
> > On Fri, Jan 17, 2020 at 06:41:02PM -0500, Tom Lane wrote:
> >> I'd be okay with a hook that there was a way to override ("yes,
> >> I know what I'm doing, this doesn't require a catversion change").
> >> But there's no way to do that is there?
>
> > I'm pretty sure there is. The program called by the commit hook can
> > prompt the user for input.
>
> ... um, but the commit hook in question would run on the repo server.
> Is there really something in the git protocol that would allow sending
> this sort of interaction back to the person running "git push"?

According to the folks I consulted, that would require special magic
on the client side.

How about something that sent an email or otherwise signaled the
person pushing that this situation obtained? It's not ideal, but it's
centralized, so harder to get inconsistent.

> I think you are right that individual committers could set up such hooks
> in their own private repos. But that's not what was being suggested,
> or so I thought.

Distributing the problem by asking people to have those hooks on their
private repo seems like a suboptimal move. Change dev boxes, and watch
your carefully structured safeguards vanish.

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-01-19 21:04:42 pgsql: Silence minor compiler warnings.
Previous Message Tom Lane 2020-01-19 17:46:19 Re: pgsql: Add a non-strict version of jsonb_set