| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tv(at)fuzzy(dot)cz>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: SlabCheck leaks memory into TopMemoryContext |
| Date: | 2020-01-16 20:21:28 |
| Message-ID: | 20200116202128.m7b76msbd5d6asmi@development |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 16, 2020 at 03:15:41PM -0500, Tom Lane wrote:
>Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
>> I think the one possible argument against this approach might be that it
>> adds a field to the struct, so if you have an extension using a Slab
>> context, it'll break if you don't rebuild it. But that only matters if
>> we want to backpatch it (which I think is not the plan) and with memory
>> context checking enabled (which does not apply to regular packages).
>
>Huh? That struct is private in slab.c, no? Any outside code relying
>on its contents deserves to break.
>
Ah, right. Silly me.
>I do think we ought to back-patch this, given the horrible results
>Andres showed.
>
OK.
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-01-16 20:21:38 | Re: making the backend's json parser work in frontend code |
| Previous Message | Tom Lane | 2020-01-16 20:15:41 | Re: SlabCheck leaks memory into TopMemoryContext |