Re: Rearranging ALTER TABLE to avoid multi-operations bugs

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Rearranging ALTER TABLE to avoid multi-operations bugs
Date: 2020-01-15 17:11:57
Message-ID: 20200115171157.GA11146@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-Jan-14, Tom Lane wrote:

> I wrote:
> > [ fix-alter-table-order-of-operations-3.patch ]
>
> Rebased again, fixing a minor conflict with f595117e2.
>
> > I'd kind of like to get this cleared out of my queue soon.
> > Does anyone intend to review it further?
>
> If I don't hear objections pretty darn quick, I'm going to
> go ahead and push this.

I didn't review in detail, but it seems good to me. I especially liked
getting rid of the ProcessedConstraint code, and the additional test
cases.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Maciek Sakrejda 2020-01-15 17:12:04 Re: Duplicate Workers entries in some EXPLAIN plans
Previous Message Alvaro Herrera 2020-01-15 17:11:10 Re: progress report for ANALYZE