| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench - use pg logging capabilities |
| Date: | 2020-01-10 00:45:46 |
| Message-ID: | 20200110004546.GE1702@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 09, 2020 at 09:27:42PM -0300, Alvaro Herrera wrote:
> On 2020-Jan-09, Fabien COELHO wrote:
>> - if (unlikely(__pg_log_level <= PG_LOG_DEBUG))
>> + if (pg_log_debug_level)
>> {
>
> Umm ... I find the original exceedingly ugly, but the new line is
> totally impenetrable.
Maybe just a pg_logging_get_level() for consistency with the
_set_level() one, and then compare the returned result with
PG_LOG_DEBUG in pgbench?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Deng, Gang | 2020-01-10 00:52:42 | RE: [PATCH] Resolve Parallel Hash Join Performance Issue |
| Previous Message | Tom Lane | 2020-01-10 00:40:12 | Re: logical decoding : exceeded maxAllocatedDescs for .spill files |