Re: pgsql: pg_stat_activity: show NULL stmt start time for walsenders

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: pg_stat_activity: show NULL stmt start time for walsenders
Date: 2020-01-08 01:58:44
Message-ID: 20200108015844.GD3413@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi Alvaro,

On Tue, Jan 07, 2020 at 06:16:24PM -0300, Alvaro Herrera wrote:
> So I misidentified things; it's not commit be87b70b6117 (pg11) that put
> auxiliary processes in pg_stat_activity, but fc70a4b0df38 (pg10). So I
> applied it back to pg10 also. (I did verify that walsenders appear with
> a xact_time in pg_stat_activity in pg10 before this patch, and not
> afterwards.)
>
> We're still computing useless xact start timestamps in branches 9.4 -
> 9.6, but I don't think we care. (If we do care, then we probably also
> care about xact *stop* time ... but meh.)

This commit has angered the buildfarm gods on HEAD and stable
branches, with failures in subscriptionCheck.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2020-01-08 02:59:38 Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Previous Message Michael Paquier 2020-01-08 01:37:51 pgsql: Revert "Forbid DROP SCHEMA on temporary namespaces"