Re: Assert failure due to "drop schema pg_temp_3 cascade" for temporary tables and \d+ is not showing any info after drooping temp table schema

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Mahendra Singh <mahi6run(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Assert failure due to "drop schema pg_temp_3 cascade" for temporary tables and \d+ is not showing any info after drooping temp table schema
Date: 2020-01-08 01:56:01
Message-ID: 20200108015601.GB3413@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Tue, Jan 07, 2020 at 07:55:17PM -0500, Tom Lane wrote:
> * Please revert a052f6c as a separate commit specifically doing that,
> so that when it comes time to make the release notes, it's clear that
> a052f6c doesn't require documentation.

Okay. Committed the revert first then.

> * I think the check on log_min_messages <= LOG is probably wrong, since
> LOG sorts out of order for this purpose. Compare is_log_level_output()
> in elog.c. I'd suggest not bothering with trying to optimize away the
> get_namespace_name call here; we shouldn't be in this code path often
> enough for performance to matter, and nobody ever cared about it before.

Done.

> * I don't greatly like the notation
> dropping orphan temp table \"%s.(null).%s\" ...
> and I bet Robert won't either. Not sure offhand about a better
> idea --- maybe
> dropping orphan temp table \"%s\" with OID %u in database \"%s\"

And done this way as per the attached. I am of course open to
objections or better ideas, though this looks formulation looks pretty
good to me. Robert?
--
Michael

Attachment Content-Type Size
drop-temp-schema-adjust-v3.patch text/x-diff 1.2 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2020-01-08 08:19:30 Re: REINDEX CONCURRENTLY unexpectedly fails
Previous Message Tom Lane 2020-01-08 00:55:17 Re: Assert failure due to "drop schema pg_temp_3 cascade" for temporary tables and \d+ is not showing any info after drooping temp table schema

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-01-08 01:56:30 Re: [PATCH] Increase the maximum value track_activity_query_size
Previous Message Thomas Munro 2020-01-08 01:49:48 Re: Consolidate 'unique array values' logic into a reusable function?