doc: alter table references bogus table-specific planner parameters

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Subject: doc: alter table references bogus table-specific planner parameters
Date: 2020-01-06 02:56:23
Message-ID: 20200106025623.GA12066@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-performance

commit 6f3a13ff058f15d565a30c16c0c2cb14cc994e42 Enhance docs for ALTER TABLE lock levels of storage parms
Author: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Date: Mon Mar 6 16:48:12 2017 +0530

<varlistentry>
<term><literal>SET ( <replaceable class="PARAMETER">storage_parameter</replaceable> = <replaceable class="PARAMETER">value</replaceable> [, ... ] )</literal></term>
...
- Changing fillfactor and autovacuum storage parameters acquires a <literal>SHARE UPDATE EXCLUSIVE</literal> lock.
+ <literal>SHARE UPDATE EXCLUSIVE</literal> lock will be taken for
+ fillfactor and autovacuum storage parameters, as well as the
+ following planner related parameters:
+ effective_io_concurrency, parallel_workers, seq_page_cost
+ random_page_cost, n_distinct and n_distinct_inherited.

effective_io_concurrency, seq_page_cost and random_page_cost cannot be set for
a table - reloptions.c shows that they've always been RELOPT_KIND_TABLESPACE.

n_distinct lock mode seems to have been changed and documented at e5550d5f ;
21d4e2e2 claimed to do the same, but the LOCKMODE is never used.

See also:

commit 21d4e2e20656381b4652eb675af4f6d65053607f Reduce lock levels for table storage params related to planning
Author: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Date: Mon Mar 6 16:04:31 2017 +0530

commit 47167b7907a802ed39b179c8780b76359468f076 Reduce lock levels for ALTER TABLE SET autovacuum storage options
Author: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Date: Fri Aug 14 14:19:28 2015 +0100

commit e5550d5fec66aa74caad1f79b79826ec64898688 Reduce lock levels of some ALTER TABLE cmds
Author: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Date: Sun Apr 6 11:13:43 2014 -0400

commit 2dbbda02e7e688311e161a912a0ce00cde9bb6fc Reduce lock levels of CREATE TRIGGER and some ALTER TABLE, CREATE RULE actions.
Author: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Date: Wed Jul 28 05:22:24 2010 +0000

commit d86d51a95810caebcea587498068ff32fe28293e Support ALTER TABLESPACE name SET/RESET ( tablespace_options ).
Author: Robert Haas <rhaas(at)postgresql(dot)org>
Date: Tue Jan 5 21:54:00 2010 +0000

Justin

Attachment Content-Type Size
v1-0001-Fixes-for-commit-6f3a13ff.patch text/x-diff 2.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2020-01-06 03:48:52 Re: doc: alter table references bogus table-specific planner parameters
Previous Message Michael Paquier 2020-01-06 02:17:03 Re: Removal of support for OpenSSL 0.9.8 and 1.0.0

Browse pgsql-performance by date

  From Date Subject
Next Message Simon Riggs 2020-01-06 03:48:52 Re: doc: alter table references bogus table-specific planner parameters
Previous Message Justin Pryzby 2020-01-04 19:34:16 Re: allow disabling indexscans without disabling bitmapscans