| From: | Jacob Champion <pchampion(at)vmware(dot)com> |
|---|---|
| To: | "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz> |
| Cc: | "daniel(at)yesql(dot)se" <daniel(at)yesql(dot)se>, "andrew(at)dunslane(dot)net" <andrew(at)dunslane(dot)net>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [PATCH] test/ssl: rework the sslfiles Makefile target |
| Date: | 2021-09-03 23:21:59 |
| Message-ID: | 20199146fd61b7ae4bb4251c1b0a8c8bc3dd5b6c.camel@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 2021-09-03 at 09:46 +0900, Michael Paquier wrote:
> Nice. This is neat. The split helps a lot to understand how you've
> changed things from the original implementation. As a whole, this
> looks rather committable to me.
Great!
> One small-ish comment that I have is about all the .config files we
> have at the root of src/test/ssl/, bloating the whole. I think that
> it would be a bit cleaner to put all of them in a different
> sub-directory, say just config/ or conf/.
That sounds reasonable. I won't be able to get to it before the holiday
weekend, but I can put up a patch sometime next week.
Thanks,
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2021-09-03 23:54:01 | Re: [PATCH] support tab-completion for single quote input with equal sign |
| Previous Message | Amit Langote | 2021-09-03 23:17:33 | Re: A reloption for partitioned tables - parallel_workers |