From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: error context for vacuum to include block number |
Date: | 2019-12-24 01:24:28 |
Message-ID: | 20191224012428.GK30414@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Dec 16, 2019 at 11:49:56AM +0900, Michael Paquier wrote:
> On Sun, Dec 15, 2019 at 10:27:12AM -0600, Justin Pryzby wrote:
> > I named it so because it calls both lazy_vacuum_index
> > ("PROGRESS_VACUUM_PHASE_VACUUM_INDEX") and
> > lazy_vacuum_heap("PROGRESS_VACUUM_PHASE_VACUUM_HEAP")
> >
> > I suppose you don't think the other way around is better?
> > lazy_vacuum_index_heap
>
> Dunno. Let's see if others have other thoughts on the matter. FWIW,
> I have a long history at naming things in a way others don't like :)
I renamed.
And deduplicated two more hunks into a 2nd function.
(I'm also including the changes I mentioned here ... in case anyone cares to
comment or review).
https://www.postgresql.org/message-id/20191220171132.GB30414%40telsasoft.com
Attachment | Content-Type | Size |
---|---|---|
v6-0001-Rename-buf-to-avoid-shadowing-buf-of-another-type.patch | text/x-diff | 2.7 KB |
v6-0002-deduplication.patch | text/x-diff | 5.5 KB |
v6-0003-dedup2-skip_blocks.patch | text/x-diff | 9.1 KB |
v6-0004-vacuum-errcontext-to-show-block-being-processed.patch | text/x-diff | 3.7 KB |
v6-0005-add-errcontext-callback-in-lazy_vacuum_heap-too.patch | text/x-diff | 1.8 KB |
v6-0006-Print-debug-line-before-starting-each-vacuum-step.patch | text/x-diff | 1.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2019-12-24 01:59:45 | Re: unsupportable composite type partition keys |
Previous Message | Amit Langote | 2019-12-24 01:20:28 | Re: unsupportable composite type partition keys |